Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: throw error if local network permissions are not enabled #178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sudharsangs
Copy link

A fix to address #177
Have modified NsdServiceImpl.java and RNZeroconf.m to throw errors if local network permissions are not given

@ManabBala
Copy link

@sudharsangs bro, can you help me implement this library with expo? i am trying hard but noting seems to work.Tried expo go build and custom dev build. please...Need this for and iot project.

@sudharsangs
Copy link
Author

@sudharsangs bro, can you help me implement this library with expo? i am trying hard but noting seems to work.Tried expo go build and custom dev build. please...Need this for and iot project.

To make it work with expo, try prebuild once if it doesn't work you need to eject as far as I know

@ManabBala
Copy link

@sudharsangs thanks for the replay. this native module have some permission mentioned so i think this might need and expo config-plugin to work with expo. there are some plugins for native library in GH(https://github.com/expo/config-plugins).
Can you please guide/help me write a expo plugin for this library? really need this for IOT devices discovery in local network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants